feat: Add endpoint on Polling Agent to kill the current task if task is in cancelling status #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneojgurhem
requested review from
ngruelaneo,
alouvion-aneo,
jfonseca-aneo and
lemaitre-aneo
ngruelaneo
reviewed
Feb 7, 2023
ngruelaneo
reviewed
Feb 7, 2023
aneojgurhem
force-pushed
the
jg/cancelrunningtask
branch
from
7719caf
to
aa1ae18
Compare
ngruelaneo
previously approved these changes
Feb 7, 2023
…is in cancelling status
aneojgurhem
force-pushed
the
jg/cancelrunningtask
branch
from
aa1ae18
to
57c7ee0
Compare
ngruelaneo
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint in the Agent to cancel the current task if the task is in cancelling state. It updates the taskData in the TaskHandler and eventually trigger the cancellation token if the task is in cancelling status.
fix aneoconsulting/ArmoniK#510