Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid calling GetResultId by caching the value in BaseClientSubmitter #212

Closed
wants to merge 24 commits into from
Closed

fix: avoid calling GetResultId by caching the value in BaseClientSubmitter #212

wants to merge 24 commits into from

Commits on Aug 21, 2023

  1. refactor: Start deep refactor of the client part of the project.

    @wkirschenmann
    wkirschenmann committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    9d58564 View commit details
    Browse the repository at this point in the history

  2. Remove retry code and calls to GetResultId.

    @wkirschenmann
    wkirschenmann committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    394da0c View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Merge branch 'main' into WK-clean

    @wkirschenmann
    wkirschenmann authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9288898 View commit details
    Browse the repository at this point in the history

  2. Apply reformat

    @wkirschenmann
    wkirschenmann committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b4dacc0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Merge branch 'wk_clean-csproj' into WK-clean

    @wkirschenmann
    wkirschenmann committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5d6a805 View commit details
    Browse the repository at this point in the history

  2. Apply reviews

    @wkirschenmann
    wkirschenmann committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d6edac0 View commit details
    Browse the repository at this point in the history

  3. Restore language version 10

    @wkirschenmann
    wkirschenmann committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f694288 View commit details
    Browse the repository at this point in the history

  4. Apply format

    @wkirschenmann
    wkirschenmann committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b2fcf50 View commit details
    Browse the repository at this point in the history

  5. Add tests about retry management.

    @wkirschenmann
    wkirschenmann committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    59f1bab View commit details
    Browse the repository at this point in the history

  6. Avoids different retry mechanisms to mix each other.

    @wkirschenmann
    wkirschenmann committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    505065c View commit details
    Browse the repository at this point in the history

  7. Correct retry logs

    @wkirschenmann
    wkirschenmann committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    fa230ac View commit details
    Browse the repository at this point in the history

  8. Handle the case where download returns null.

    @wkirschenmann
    wkirschenmann committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ff707fd View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into WK-clean

    @wkirschenmann
    wkirschenmann committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    144c2cd View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Use new version of core.

    @wkirschenmann
    wkirschenmann committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3049c26 View commit details
    Browse the repository at this point in the history

  2. Begin cleaning remaining retries.

    @wkirschenmann
    wkirschenmann committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    76a87c1 View commit details
    Browse the repository at this point in the history

  3. Reverting most retry code 

    But still using new ApiExt methods.
    @wkirschenmann
    wkirschenmann committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e92c17f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into WK-clean

    @wkirschenmann
    wkirschenmann authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    cff652b View commit details
    Browse the repository at this point in the history

  5. Correct BlockRequest

    @wkirschenmann
    wkirschenmann committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d8c22b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Deactivate legacy retry policies

    @wkirschenmann
    wkirschenmann committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    685d2e9 View commit details
    Browse the repository at this point in the history

  2. Clean BaseClientSubmitter.cs

    @wkirschenmann
    wkirschenmann committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    95e77e5 View commit details
    Browse the repository at this point in the history

  3. feat: avoids calls to GetResultId by caching the values in BaseClient… 

    …Submitter
    @wkirschenmann
    wkirschenmann committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    3fca03b View commit details
    Browse the repository at this point in the history

  4. Add documentation

    @wkirschenmann
    wkirschenmann committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d0a5215 View commit details
    Browse the repository at this point in the history

  5. ChannelPool becomes async.

    @wkirschenmann
    wkirschenmann committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    555a508 View commit details
    Browse the repository at this point in the history

  6. fix: channelPool lifecycle.

    @wkirschenmann
    wkirschenmann committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    4a464da View commit details
    Browse the repository at this point in the history