$state.go fails to transition to the same state

[the-simian]

If I am in a certain stay, such as x.y if I attempt to transition into the same state I am currently in, possibly with updated state params, the transition does not fire.

//in x.y
$state.go('x.y', { someParam: 'newvalue'}); //nothing happens

This occurs if reloadOnSearch is true (it should be by default anyways) and also if you set {reload: true}

//in x.y
$state.go('x.y', { someParam: 'newvalue'}, { reload: true}); //also nope

This occurs in 0.2.14, but not 0.2.13

[the-simian]

references #1933

[the-simian]

@christopherthielen

Ok I got it the bug repro working. It seems to be related, specifically to null being assigned to the value on a property of $stateParams. It turns out the application this was discovered in was doing exactly this. If you don't use null as a value, it seems to work

I made an example with both 0.2.13 and 0.2.14

• Version 0.2.13 - working
• Version 0.2.14 -not working

Try clicking the buttons one after the other in each example/

The breaking code is the behavior of something like this:

  $state.go('default.search', {param1: 'yo2', param2: null})

In the past, setting a $stateParam to null would still change state, now it prevents a state change entirely.

Let me know if there's anything else I can do in this plunkr setup to help demonstrate the problem. Its somewhat hard to really show, because its hard to see the url itself in the plunkr. I seem to recall setting a $stateParam to null removing it entirely from the url.

[christopherthielen]

This is caused by the 'string' param Type .is() method changing from regexp test to typeof(val) === 'string'. I hadn't intended to change the behavior of string Type until a breaking change release. Sorry about that. 0.2.15 will make string types optional once more.

[the-simian]

@christopherthielen Thanks for looking into this! Let me know if there's anything else I can do to help out!