Skip to content

Commit

Permalink
fix(common): remove code duplication between entry-points (#51500)
Browse files Browse the repository at this point in the history
The common packages were duplicating a little bit of code due
to relative imports between entry-points. This caused bundlers to
inline shared functions twice in both FESM outputs.i

PR Close #51500
  • Loading branch information
devversion authored and thePunderWoman committed Aug 29, 2023
1 parent 698c058 commit 86c5e34
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions packages/common/src/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ export {VERSION} from './version';
export {ViewportScroller, NullViewportScroller as ɵNullViewportScroller} from './viewport_scroller';
export {XhrFactory} from './xhr';
export {IMAGE_CONFIG, ImageConfig, IMAGE_LOADER, ImageLoader, ImageLoaderConfig, NgOptimizedImage, PRECONNECT_CHECK_BLOCKLIST, provideCloudflareLoader, provideCloudinaryLoader, provideImageKitLoader, provideImgixLoader} from './directives/ng_optimized_image';
export {normalizeQueryParams as ɵnormalizeQueryParams} from './location/util';
4 changes: 1 addition & 3 deletions packages/common/testing/src/location_mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,10 @@
* found in the LICENSE file at https://angular.io/license
*/

import {Location, LocationStrategy} from '@angular/common';
import {Location, LocationStrategy, ɵnormalizeQueryParams as normalizeQueryParams} from '@angular/common';
import {EventEmitter, Injectable} from '@angular/core';
import {SubscriptionLike} from 'rxjs';

import {normalizeQueryParams} from '../../src/location/util';

/**
* A spy for {@link Location} that allows tests to fire simulated location events.
*
Expand Down

0 comments on commit 86c5e34

Please sign in to comment.