Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an easy way to configure new pipes #2901

Closed
vsavkin opened this issue Jul 6, 2015 · 4 comments
Closed

Provide an easy way to configure new pipes #2901

vsavkin opened this issue Jul 6, 2015 · 4 comments
Assignees
Labels
effort2: days feature Issue that requests a new feature
Milestone

Comments

@vsavkin
Copy link
Contributor

vsavkin commented Jul 6, 2015

Currently pipes are global and are not easily configurable. We need to make them scoped to a component and provide a way to easily configure them.

Proposal:

@Component({
  viewInjector: [
         bind(Pipes).toFactory(Pipes.append({
                async: [newAsyncPipe]
         })
  ]
})
@vsavkin vsavkin added this to the alpha-31 milestone Jul 6, 2015
@vsavkin vsavkin self-assigned this Jul 6, 2015
@jeffbcross jeffbcross assigned jeffbcross and vsavkin and unassigned vsavkin and jeffbcross Jul 6, 2015
@naomiblack naomiblack added the feature Issue that requests a new feature label Jul 8, 2015
@vsavkin vsavkin assigned jeffbcross and unassigned vsavkin Jul 8, 2015
@jeffbcross
Copy link
Contributor

@btford and @matsko heads up that we're renaming PipeRegistry to Pipes. What do you think of changing RouteRegistry to Routes?

@matsko
Copy link
Contributor

matsko commented Jul 9, 2015

Works for me.

@btford
Copy link
Contributor

btford commented Jul 9, 2015

I think RouteRegistry is a better name than Routes since there are so many class names that already have Route in them. But there may be a better name for RouteRegistry; we'd have to chat some to decide.

jeffbcross added a commit to jeffbcross/angular that referenced this issue Jul 9, 2015
This change allows creation of a new Pipes object with new pipes appended
to pipes of an inherited Pipes.

Closes angular#2901
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jul 10, 2015
This change allows creation of a new Pipes object with new pipes appended
to pipes of an inherited Pipes.

Closes angular#2901
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jul 10, 2015
This change allows creation of a new Pipes object with new pipes appended
to pipes of an inherited Pipes.

Closes angular#2901
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jul 10, 2015
This change allows creation of a new Pipes object with new pipes appended
to pipes of an inherited Pipes.

Closes angular#2901
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jul 10, 2015
This change allows creation of a new Pipes object with new pipes appended
to pipes of an inherited Pipes.

Closes angular#2901
jteplitz pushed a commit to jteplitz/angular that referenced this issue Jul 14, 2015
This change allows creation of a new Pipes binding with new pipes appended
to pipes of an inherited Pipes instance.

Closes angular#2901
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort2: days feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

5 participants