fix(material/select): remove incompatible aria-autocomplete attribute #29645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
mmalerba and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
Aug 26, 2024
essjay05
force-pushed
the
mat-select-remove-incompatible-aria-autocomplete-attr
branch
4 times, most recently
from
92e2d25
to
a241fdb
Compare
essjay05
force-pushed
the
mat-select-remove-incompatible-aria-autocomplete-attr
branch
2 times, most recently
from
44afd16
to
501be8a
Compare
Fixes a bug reported in MatSelect where the usage of aria-autocomplete is not a valid attribute that can be used with aria role=listbox. Removes the aria-autocomplete attribute to fix the violation: aria-allowed-attr. Fixes b/352496530
essjay05
force-pushed
the
mat-select-remove-incompatible-aria-autocomplete-attr
branch
from
501be8a
to
bd1832e
Compare
andrewseguin
added
action: merge
essjay05
deleted the
mat-select-remove-incompatible-aria-autocomplete-attr
branch
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 19, 2024
After angular#29645, the assertion for `aria-autocomplete` isn't valid anymore.
crisbeto
added a commit
that referenced
this pull request
Sep 19, 2024
After #29645, the assertion for `aria-autocomplete` isn't valid anymore.
crisbeto
added a commit
that referenced
this pull request
Sep 19, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug reported in MatSelect where the usage of aria-autocomplete is not a valid attribute that can be used with aria role=listbox. Removes the aria-autocomplete attribute to fix the violation: aria-allowed-attr.
W3 Documentation on allowed attributes for role="listbox"
Fixes b/352496530