Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Commit

Permalink
fix(layout): Firefox and flex layout with min-height
Browse files Browse the repository at this point in the history
* while Chrome has fixed this bug, Firefox still needs this workaround.

Fixes #7382.
  • Loading branch information
ThomasBurleson committed Mar 3, 2016
1 parent 6411cc4 commit faf5845
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion src/core/style/layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@
max-width: #{$value};
max-height: 100%;
box-sizing: border-box;

// Bug workaround for http://crbug.com/546034 - flex issues on Chrome 48
@if $i == 0 { min-width: 0; }
}

.layout-column > .#{$flexName}-#{$i * 5},
Expand All @@ -149,18 +152,27 @@
max-width: 100%;
max-height: #{$value};
box-sizing: border-box;
}

// Bug workaround for http://crbug.com/546034 - flex issues on Chrome 48
@if $i == 0 { min-height: 0; }
}

}

.layout-row, .layout#{$name}-row {
> .#{$flexName}-33 , > .#{$flexName}-33 { flex: 1 1 33.33%; max-width: 33.33%; max-height: 100%; box-sizing: border-box; }
> .#{$flexName}-66 , > .#{$flexName}-66 { flex: 1 1 66.66%; max-width: 66.66%; max-height: 100%; box-sizing: border-box; }

// Bug workaround for http://crbug.com/546034 - flex issues on Chrome 48
> .flex { min-width: 0; }

}
.layout-column, .layout#{$name}-column {
> .#{$flexName}-33 , > .#{$flexName}-33 { flex: 1 1 33.33%; max-width: 100%; max-height: 33.33%; box-sizing: border-box; }
> .#{$flexName}-66 , > .#{$flexName}-66 { flex: 1 1 66.66%; max-width: 100%; max-height: 66.66%; box-sizing: border-box; }

// Bug workaround for http://crbug.com/546034 - flex issues on Chrome 48
> .flex { min-height: 0; }
}

}
Expand Down

0 comments on commit faf5845

Please sign in to comment.