-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Broad style rules in structure.scss can cause conflicts #1442
Comments
That is good feedback. But if we don't provide defaults, then you'd ALWAYS have to provide a CSS class for headings, which would be a pain. Do you really need |
Thanks. Yes I don't need [btw, sorry i accidentally deleted my comment, re-posting here again]
|
@PrashantAshok wouldn't you already have to override the browser's default font size anyway? I am definitely thinking hard on whether the styles are in fact too broad, but I want to consider all angles. Libraries like Bootstrap do define default font sizes for headings. I think as long as they are easy to override, that is the key. |
Yep. Libraries like bootstrap are easy to override, but I am thinking maybe material leaves it to bootstrap/others to define defaults and just has material specific styles? |
Great feedback from @jelbourn:
Based on that and your concerns @PrashantAshok, I'm thinking the base |
I think that should work, something like |
(Edited) A body class is not a good idea, as it turns out. We are investigating solutions for this, so stay tuned. |
@PrashantAshok have a look at #2042, it should sort everything out. |
Looks great @marcysutton . Thanks. |
The very broad rules in structure.scss (example below) can cause issues when used alongside another component library. We should explore ways to apply these styles more selectively.
The text was updated successfully, but these errors were encountered: