This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feature(button): change md-icon-button to use round ripple effect #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @robertmesserle , @matthewrfindley created separate Ripple effect files to simulate inheritance-like solution. Not sure I like this approach.... what are your thoughts ? |
matthewrfindley
force-pushed
the
feature/md-button-rounded-focus-state
branch
from
8c4893b
to
52840aa
Compare
| @@ -57,7 +57,7 @@ angular | |||
| * </md-button> | |||
| * </hljs> | |||
| */ | |||
| function MdButtonDirective($mdInkRipple, $mdTheming, $mdAria, $timeout) { | |||
| function MdButtonDirective($mdButtonInkRipple, $mdTheming, $mdAria, $timeout) { | |||
There was a problem hiding this comment.
I think I like this approach as opposed to a bunch of boilerplate functions on the original $mdInkRipple
|
@ThomasBurleson @matthewrfindley I much prefer this approach to our original approach. LGTM! |
BREAKING CHANGE: Removed attach(button|tab|checkbox|list)Behavior
in favor of composing an injectable ripple service specific to
your target. $mdInkRipple was too aware of how to configure
components. You now have access to $mdButtonInkRipple,
$mdTabInkRipple, $mdListInkRipple, $mdCheckboxInkRipple.
Change your code from this:
``` javascript
function MyService($mdInkRipple) {
//... Included for brevity
$mdInkRipple.attachButtonBehavior(scope, element, options);
}
```
To this:
``` javascript
function MyService($mdButtonInkRipple) {
//... Included for brevity
$mdButtonInkRipple.attach(scope, element, options);
}
```
- Removed during a rebase
matthewrfindley
force-pushed
the
feature/md-button-rounded-focus-state
branch
from
80273fc
to
82bfa9b
Compare
|
@ThomasBurleson this has been rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue -> #2373.
A breaking change was introduced in 0300c3a. The breaking change removes attach{insert component name}Behavior from $mdInkRipple to seperate the concern of configuring ripple effects for specific component types and the core ripple effect behavior.
This PR could be broken up into 1) implement feature 2) refactor inkRipple if this change is too extreme to bring into the project ATM.