Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdDialog: clickOutsideToClose does not remove the element in FF #2479

Closed
2009 opened this issue Apr 22, 2015 · 4 comments
Closed

mdDialog: clickOutsideToClose does not remove the element in FF #2479

2009 opened this issue Apr 22, 2015 · 4 comments

Comments

@2009
Copy link

2009 commented Apr 22, 2015

See this demo: http://codepen.io/anon/pen/EjxyXL

After showing the dialog, clicking outside or hitting escape leaves the element in the DOM, not letting you open it a second time.
Happens with both options clickOutsideToClose and escapeToClose.
I've tested this in chrome and it works fine.

Firefox version is 31.0

@ThomasBurleson ThomasBurleson added the for: internal contributor The team will address this issue and community PRs are not requested. label Apr 24, 2015
@Axel186
Copy link

Axel186 commented Apr 27, 2015

+1

@dmitriz
Copy link

dmitriz commented May 6, 2015

Same Bug in Chrome 42.0.2311.90 :

  • Click outside doesn't close any of the dialogs.
  • Press Escape closes the 3rd dialog but not 1 and 2:

https://material.angularjs.org/#/demo/material.components.dialog


Exactly the same (buggy) behavior:

Firefox 34.0.5
Safari 6.2.4 (8537.85.13.7)
Opera 18.0.1284.68

@ThomasBurleson ThomasBurleson added Contributor and removed for: internal contributor The team will address this issue and community PRs are not requested. labels May 27, 2015
@ThomasBurleson ThomasBurleson added this to the Backlog milestone May 27, 2015
@kevin-frugier
Copy link

I confirm the bug reported by @dmitriz , the same code on Angular Material 0.8.3 worked fine (dialogs could be closed by clicking outside). But in Angular Material 0.9.0, 0.9.3 & 0.9.4 (on Chrome & FF), dialogs can't be skipped anymore. This is really annoying since 1.it's a regression compared to previous versions 2.it forces us (unless an easy patch is provided) to redesign our dialogs to have a "close" button when it was not needed before.

Since it's not only a FF issue anymore (even Angular Material demo fails on Chrome & FF), maybe the issue should be renamed to make it more generic.

@mdekrey
Copy link

mdekrey commented Jun 17, 2015

👍

Definitely not the behavior as described at https://material.angularjs.org/0.10.0/#/demo/material.components.dialog for Chrome 43.0.2357.124.

@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants