This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
$mdToast: should hide after duration tests false positive #2728
Comments
adamweeks
added a commit
to adamweeks/material
that referenced
this issue
May 5, 2015
In the `should hide after duration` unit test, an option value is provided to the parameter `hideTimeout`. This option is not valid and should be `hideDelay`. The test passes because the toast will default to hide after 3000 anyway. angular#2728
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the
toast.spec.js
file, there is a unit test for'should hide after duration'
that gives a false positive:https:/angular/material/blob/master/src/components/toast/toast.spec.js#L151
In the
setup
command, it passes an optionhideTimeout
. This option should behideDelay
. The test passes because there is an auto-hide on nullhideDelay
options.This test would fail if the
$timeout.flush()
was changed to$timeout.flush(1234)
.The text was updated successfully, but these errors were encountered: