This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
ng-disabled on md-icon in md-list-item does not work #3356
Comments
Duplicate of #3176 |
I dont think #3176 covers the case for ng-disabled. |
Appears to still be an issue in 1.0.0-rc2: http://codepen.io/topherfangio/pen/EVpeBV Prioritizing for RC4 (don't think we can get it into RC3). |
topherfangio
added a commit
that referenced
this issue
Nov 13, 2015
When an secondary md-icon was used in combination with a checkbox, the md-icon was only copying the `ng-click` attribute instead of all attributes including things like `ng-disabled`. Fix by ensuring we copy all relevant attributes to the wrapper. Fixes #3356.
This has a PR waiting, but it looks like I need to rebase it before we merge. Will definitely get this merged into RC6. |
topherfangio
added
pr: merge ready
This PR is ready for a caretaker to review
in progress
Mainly for in progress PRs, but may be used for issues that require multiple PRs
labels
Nov 23, 2015
topherfangio
added a commit
that referenced
this issue
Nov 23, 2015
When an secondary md-icon was used in combination with a checkbox, the md-icon was only copying the `ng-click` attribute instead of all attributes including things like `ng-disabled`. Fix by ensuring we copy all relevant attributes to the wrapper. Fixes #3356.
ThomasBurleson
removed
the
in progress
Mainly for in progress PRs, but may be used for issues that require multiple PRs
label
Jan 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When ng-disabled is applied on md-icon acting as a secondary on md-list-item, it does not have any effect on the dynamically generated button which still fires.
Here is a codepen: http://codepen.io/anon/pen/bdoqLb
The text was updated successfully, but these errors were encountered: