Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-fab-toolbar - strange margin #3390

Closed
Arth95 opened this issue Jun 22, 2015 · 5 comments
Closed

md-fab-toolbar - strange margin #3390

Arth95 opened this issue Jun 22, 2015 · 5 comments
Assignees
Labels
pr: merge ready This PR is ready for a caretaker to review
Milestone

Comments

@Arth95
Copy link

Arth95 commented Jun 22, 2015

Hi!
I've put md-fab-toolbar in my ui-router template and this happens:
bez tytulu
Template is in:
md-content
div layout="column" ui-view
/div
/md-content
In template md-fab-toolbar is next to table in div.
This happens also when I put this element outside ui-view.

@topherfangio
Copy link
Contributor

Any chance you could provide a Codepen so I can debug the issue a bit further?

@topherfangio topherfangio self-assigned this Jun 23, 2015
@minhajkk
Copy link

@topherfangio I'm also facing same problem here's the codepen http://codepen.io/anon/pen/GJOwaM

@ThomasBurleson ThomasBurleson modified the milestone: 0.11.0 Jul 6, 2015
@EndymionUSA
Copy link

change

ng-class="md-right"

to

class="md-left"

Please close this issue.

@topherfangio
Copy link
Contributor

@EndymionUSA is definitely correct, you should use class="md-left" or class="md-right" instead of ng-class, however, it looks like there may be some other issues with this.

On the example, I'm seeing the house icon appear above the FAB even when the toolbar isn't visible. I'll look into this a bit further, but it's possible it has been fixed with some other recent updates.

@topherfangio topherfangio added the needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community label Aug 6, 2015
@topherfangio
Copy link
Contributor

Quick note, in master/0.11.0 we have made some breaking changes to make the fabToolbar better conform with the options in fabSpeedDial. Instead of manually setting the class, you should now use the md-direction attribute set to left or right.

Example:

<md-fab-toolbar md-direction='left'>
  ...
</md-fab-toolbar>

This should fix this issue once #4185 gets merged.

@topherfangio topherfangio added pr: merge ready This PR is ready for a caretaker to review and removed needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels Aug 15, 2015
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
… expression.

Fix `md-direction` attribute to use the correct scope initialization.

Fixes angular#3390. Closes angular#4185.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants