Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-chips: add "md-selected-item-change" event/method and allow selection on readonly #3413

Closed
stefan-schweiger opened this issue Jun 23, 2015 · 2 comments
Closed

md-chips: add "md-selected-item-change" event/method and allow selection on readonly #3413

stefan-schweiger opened this issue Jun 23, 2015 · 2 comments
Assignees
@topherfangio
Labels
pr: merge ready This PR is ready for a caretaker to review
Milestone
1.0-rc1

Comments

@stefan-schweiger
Copy link

I'm really missing a convenient way of knowing when a md-chip was selected, like md-autocomplete has implemented it.

<md-chips ng-model="vm.chips"
          md-selected-item-change="vm.chipSelected(item)">
</md-chips>

Also you should be able to select chips when the control is set to readonly, the only situation where you shouldn't be able to do this in my opinion is when the control is disabled.

EDIT: same goes for static chips, also some way of setting the selected chip would be a nice to have.
@ThomasBurleson ThomasBurleson modified the milestone: 0.11.0 Jul 6, 2015
topherfangio added a commit that referenced this issue Aug 10, 2015
@topherfangio
feat(mdChips): Add md-on-select expression support.
99ebf5c 
Users want a way to be notified when a chip is selected.

closes #3413
@topherfangio topherfangio mentioned this issue Aug 10, 2015
Closed
@topherfangio topherfangio added the pr: merge ready This PR is ready for a caretaker to review label Aug 11, 2015
topherfangio added a commit that referenced this issue Aug 13, 2015
@topherfangio
feat(mdChips): Add md-on-select expression support.
2a19bed 
Users want a way to be notified when a chip is selected.

closes #3413
topherfangio added a commit that referenced this issue Aug 13, 2015
@topherfangio
feat(mdChips): Add md-on-select expression support.
369c20f 
Users want a way to be notified when a chip is selected.

closes #3413
topherfangio added a commit that referenced this issue Aug 13, 2015
@topherfangio
feat(mdChips): Add md-on-select expression support.
d62470c 
Users want a way to be notified when a chip is selected.

closes #3413
topherfangio added a commit that referenced this issue Aug 14, 2015
@topherfangio
feat(mdChips): Add md-on-select expression support.
407c1aa 
Users want a way to be notified when a chip is selected.

closes #3413
topherfangio added a commit that referenced this issue Aug 14, 2015
@topherfangio @ThomasBurleson
feat(mdChips): Add md-on-select expression support.
a1b34c7 
Users want a way to be notified when a chip is selected.

fix #3413. closes #4088.
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
@topherfangio @kennethcachia
feat(mdChips): Add md-on-select expression support.
0f993d4 
Users want a way to be notified when a chip is selected.

fix angular#3413. closes angular#4088.
@ryananthonydrake
Copy link

When will this be merged in to master?

@topherfangio
Copy link
Contributor

This was merged in 333984f on Aug 14 and should be in the official 11.1 release which is already available. If it isn't working as you expect, please open a new issue and reference this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@topherfangio topherfangio

Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.0-rc1
Development

Successfully merging a pull request may close this issue.

feat(mdChips): Add md-on-select expression support. angular/material
5 participants
@topherfangio @ThomasBurleson @ryananthonydrake @stefan-schweiger @typotter