This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(fabSpeedDial): fix many visual issues #3468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| angular.module('fabSpeedDialModalDemo', ['ngMaterial']) | ||
| .controller('AppCtrl', function($scope, $mdDialog) { | ||
| $scope.demo = { |
There was a problem hiding this comment.
It would be better to use controllerAs syntax.
|
It would be better to avoid You might be able to avoid |
topherfangio
force-pushed
the
wip/speed_dial_tooltips
branch
from
9335f61
to
d09952f
Compare
|
@gkalpak Done and done :-) Please let me know if you see anything else that needs changing! |
| $scope.demo = { | ||
| topDirections: ['left', 'up'], | ||
| bottomDirections: ['down', 'right'], | ||
| .controller('DemoCtrl', function($scope) { |
There was a problem hiding this comment.
No need to inject $scope any more.
|
@topherfangio, careful what you ask for :) |
* maintain state when focusing/bluring/tabbing through actions speed dial would previously show a very short and erroneous animation when tabbing, or rapidly blurring/focusing, through child items * add demo showing tooltip usage * fix $digest in-progress error when opening a dialog cebor reported a $digest in progress bug when trying to open a dialog from within the speed dial; haven't figured out how to create a test that demonstrates it, but I added a demo which shows failure * animations fail on Safari update webkitTransform styles and set height to initial instead of 100% * make changes suggested by gkalpak * more fixes suggested by gkalpak closes #3213, closes #3338, closes #3277, closes #3236, closes #3375
topherfangio
force-pushed
the
wip/speed_dial_tooltips
branch
from
d09952f
to
78fcf18
Compare
|
@topherfangio - nice work here. I also combined the Demos #2 & #3 while merging your PR. |
|
@ThomasBurleson Thanks so much! I was wondering myself if we should combine the demos, so I'm glad you did :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maintain state when focusing/bluring/tabbing through actions
speed dial would previously show a very short and erroneous animation
when tabbing, or rapidly blurring/focusing, through child items
add demo showing tooltip usage
fix $digest in-progress error when opening a dialog
cebor reported a $digest in progress bug when trying to open a dialog
from within the speed dial; haven't figured out how to create a test
that demonstrates it, but I added a demo which shows failure
animations fail on Safari
update webkitTransform styles and set height to initial instead of 100%
closes #3213, closes #3338, closes #3277, closes #3236, closes #3375