Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-autocomplete 'searching' progress bar not displaying #3802

Closed
hodeyp opened this issue Jul 18, 2015 · 6 comments
Closed

md-autocomplete 'searching' progress bar not displaying #3802

hodeyp opened this issue Jul 18, 2015 · 6 comments
Labels
needs: review This PR is waiting on review from the team

Comments

@hodeyp
Copy link

hodeyp commented Jul 18, 2015

I am using anmd-autocomplete to search for data that is returned from a promise. Looking at the demo a progress bar is displayed during the search but this is not appearing on master.

@yigaldviri
Copy link

+1.
The behavior isn't consistent. sometime I see the progress-bar and sometime don't.

@mikedobrin
Copy link

+1 same for me here, I have noticed that once I hide and then show autocomplete again, then focus on the value I have typed - I get this loading indicator.

I'm using 0.10.1-rc4 but the issue is reproduced on rc3 as well

@ThomasBurleson ThomasBurleson added the needs: review This PR is waiting on review from the team label Jul 31, 2015
@ThomasBurleson ThomasBurleson modified the milestone: REVISIT Jul 31, 2015
@gabguy
Copy link

gabguy commented Aug 2, 2015

+1 Md-autocomplete progressbar (the linear one) not animating on the first character when the search is an async request. On the rest of the characters the loading animation does appear

@lillylykho
Copy link

+1
I have the same behavior on my autocomplete

@macdasi
Copy link

macdasi commented Aug 2, 2015

+1
I have the same behavior on my autocomplete

@r0b-
Copy link

r0b- commented Aug 3, 2015

+1
(0.10.1-rc5)

@ThomasBurleson ThomasBurleson modified the milestones: REVISIT, Backlog Aug 10, 2015
ThomasBurleson added a commit that referenced this issue Sep 3, 2015
…ons, perf upgrades

synchronize progressLinear with similar logic used in progressCircular.

* improve animation performances
* watch md-mode for changes
* refactor animation SCSS
* enable hiding and no-animations with undefined/empty md-mode attributes
* for both indicators, use `display:inline-block;`
* update demos with enable switch
* fix query mode
* update Select to use enhanced progressCircular component
* fix autocomplete styling of progress-linear.md-mode-indeterminate

BREAKING-CHANGES

Before:

```css
md-progress-linear {
  display: block;
}
md-progress-circular {
   // display not set
   // position not set
}
```

```css
md-progress-linear {
  display: inline-block;
  position: relative;
}
md-progress-circular {
  display: inline-block;
  position: relative;
}
```

Fixes #4421. Fixes #4409. Fixes #2540. Fixes #2364. Fixes #1926. Fixes #3802.
ThomasBurleson added a commit that referenced this issue Sep 3, 2015
…ons, perf upgrades

synchronize progressLinear with similar logic used in progressCircular.

* improve animation performances
* watch md-mode for changes
* refactor animation SCSS
* enable hiding and no-animations with undefined/empty md-mode attributes
* for both indicators, use `display:inline-block;`
* update demos with enable switch
* fix query mode
* update Select to use enhanced progressCircular component
* fix autocomplete styling of progress-linear.md-mode-indeterminate
*  auto-inject md-mode attribute if missing
  *  use 'determinate' if value attribute is defined
  *  otherwise use 'indeterminate'
  *  $log.debug() notify user (via $log.debug) of injection
  *  add API doc details regarding md-mode auto-injection
* fix tests

BREAKING-CHANGES

Before:

```css
md-progress-linear {
  display: block;
}
md-progress-circular {
   // display not set
   // position not set
}
```

```css
md-progress-linear {
  display: inline-block;
  position: relative;
}
md-progress-circular {
  display: inline-block;
  position: relative;
}
```

Fixes #4421. Fixes #4409. Fixes #2540. Fixes #2364. Fixes #1926. Fixes #3802.
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
…ons, perf upgrades

synchronize progressLinear with similar logic used in progressCircular.

* improve animation performances
* watch md-mode for changes
* refactor animation SCSS
* enable hiding and no-animations with undefined/empty md-mode attributes
* for both indicators, use `display:inline-block;`
* update demos with enable switch
* fix query mode
* update Select to use enhanced progressCircular component
* fix autocomplete styling of progress-linear.md-mode-indeterminate
*  auto-inject md-mode attribute if missing
  *  use 'determinate' if value attribute is defined
  *  otherwise use 'indeterminate'
  *  $log.debug() notify user (via $log.debug) of injection
  *  add API doc details regarding md-mode auto-injection
* fix tests

BREAKING-CHANGES

Before:

```css
md-progress-linear {
  display: block;
}
md-progress-circular {
   // display not set
   // position not set
}
```

```css
md-progress-linear {
  display: block;
  position: relative;
}
md-progress-circular {
  display: block;
  position: relative;
}
```

Fixes angular#4421. Fixes angular#4409. Fixes angular#2540. Fixes angular#2364. Fixes angular#1926. Fixes angular#3802. Closes angular#4454.
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: review This PR is waiting on review from the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants