This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): resolves issue with nested tabs #5719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| function firstChild (element, tagName) { | ||
| var children = element[0].children; | ||
| for (var i = 0; i < children.length; i++) { |
There was a problem hiding this comment.
When you check the length property of an HTMLCollection object, it re-checks the DOM, which is slow. You should access the length only once.
robertmesserle
force-pushed
the
issues/4989
branch
from
60e04a5
to
c0fcb87
Compare
robertmesserle
force-pushed
the
issues/4989
branch
from
c0fcb87
to
ac3aa7d
Compare
ThomasBurleson
added
the
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4989
@ThomasBurleson @jelbourn The root cause of this was that I was using
findto find the label and body tags, when I actually needed to only look at child elements.