This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(toolbar): apply accent color to ripple and icons in toolbar. #5811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
added
needs: review
|
Issue still existing in the latest build. This PR fixes that. |
|
LGTM, Can you add transition to md-toolbar on background color? |
devversion
force-pushed
the
fix/toolbar-accent-apply
branch
from
b753d4e
to
629f41d
Compare
|
@EladBezalel - I added a transition for |
| @@ -30,6 +30,9 @@ md-toolbar { | |||
| min-height: $baseline-grid * 8; | |||
| width: 100%; | |||
|
|
|||
| transition: $swift-linear; | |||
There was a problem hiding this comment.
please use $swift-ease-in-out, cubic-bezier feels so good!
devversion
force-pushed
the
fix/toolbar-accent-apply
branch
2 times, most recently
from
a08888c
to
8719390
Compare
|
Updated, Added Cubic Transition to the Toolbar, even to SVG Icons Little lag demo, to preview the change |
|
Sweet! |
EladBezalel
added
pr: merge ready
The toolbar won't apply the accent colors to the ripple and the md-icon. Fixes angular#5341
devversion
force-pushed
the
fix/toolbar-accent-apply
branch
from
8719390
to
aec9562
Compare
|
@devversion - Nice work! |
ErinCoughlan
pushed a commit
to ErinCoughlan/material
that referenced
this pull request
Feb 9, 2016
The toolbar won't apply the accent colors to the ripple and the md-icon. Fixes angular#5341. Closes angular#5811. #breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolbar won't apply the accent colors to the ripple and the md-icon.
Fixes #5341