Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-chips small screen #5897

Closed
shantanu1227 opened this issue Nov 24, 2015 · 4 comments
Closed

md-chips small screen #5897

shantanu1227 opened this issue Nov 24, 2015 · 4 comments
Labels
P4: minor Minor issues. May not be fixed without community contributions. resolution: fixed
Milestone
1.1.0

Comments

@shantanu1227
Copy link

chips are not being selected on small screen
@devversion
Copy link
Member

How are you defining ``small screen`. Please provide Device Information.

Everything is working fine, in selecting chips on small screen 768px)

@shantanu1227
Copy link
Author

I can select chip in desktop but the chip in mobile is not being selected although it can be deleted.

angular material - demos - chips - google chrome_015
angular material - demos - chips - google chrome_016

@devversion
Copy link
Member

Yes, I can reproduce that. I did a little bit of research. It look's like the focus event won't get triggered by these touch events. If we change the tabIndex of the chips content from 1 to zero, the chip will get focused after not clicking on the text.

Update: I created a PR, which fixes that

devversion added a commit to devversion/material that referenced this issue Nov 26, 2015
@devversion
fix(chips): fix chips focus for touch devices
73a8657 
The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard

Fixes angular#5897
@devversion devversion mentioned this issue Nov 26, 2015
Closed
devversion added a commit to devversion/material that referenced this issue Dec 31, 2015
@devversion
fix(chips): fix chips focus for touch devices
0a75c8c 
The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard

Fixes angular#5897
devversion added a commit to devversion/material that referenced this issue Dec 31, 2015
@devversion
fix(chips): fix chips focus functionality
91df422 
- The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard
- At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes angular#5897 Fixes angular#5662
devversion added a commit to devversion/material that referenced this issue Jan 1, 2016
@devversion
fix(chips): fix chips focus functionality
9d9130c 
- The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard
- At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes angular#5897 Fixes angular#5662
devversion added a commit to devversion/material that referenced this issue Jan 5, 2016
@devversion
fix(chips): fix chips focus functionality
6cbf6ae 
- The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard
- At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes angular#5897 Fixes angular#5662
@topherfangio topherfangio added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Jan 6, 2016
@topherfangio topherfangio added this to the 1.0.2 milestone Jan 6, 2016
devversion added a commit to devversion/material that referenced this issue Jan 6, 2016
@devversion
fix(chips): fix chips focus functionality
50d371c 
- The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard
- At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes angular#5897 Fixes angular#5662
@a2bsoftware
Copy link

+1

@ThomasBurleson ThomasBurleson added P4: minor Minor issues. May not be fixed without community contributions. and removed priority: medium labels Jan 13, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.2, Backlog Jan 15, 2016
devversion added a commit to devversion/material that referenced this issue Feb 5, 2016
@devversion
fix(chips): fix chips focus functionality
2c6d87b 
- The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard
- At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes angular#5897 Fixes angular#5662
devversion added a commit to devversion/material that referenced this issue Feb 6, 2016
@devversion
fix(chips): fix chips focus functionality
34ea616 
- The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard
- At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes angular#5897 Fixes angular#5662
devversion added a commit to devversion/material that referenced this issue Feb 10, 2016
@devversion
fix(chips): fix chips focus functionality
1feea52 
- The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard
- At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes angular#5897 Fixes angular#5662
@topherfangio topherfangio added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Mar 8, 2016
ThomasBurleson pushed a commit that referenced this issue Apr 1, 2016
@devversion @ThomasBurleson
fix(chips): fix chips focus functionality
8c5b978 
- The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard
- At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes #5897. Fixes #5662. Closes #5941

# Conflicts:
#	src/components/chips/chips.spec.js
ThomasBurleson pushed a commit that referenced this issue Apr 1, 2016
@devversion @ThomasBurleson
fix(chips): fix chips focus functionality
cfb285c 
- The normal mobile devices won't trigger the focus on the element.
Focusing the element on `ng-click` fixes that issue.
Through keeping and redirecting to `ng-focus` it's still possible to select chips through keyboard
- At the moment, we only reset the selectedChip variable but we don't
  apply that to the view, so we need to run an async evaluation.

Fixes #5897. Fixes #5662. Closes #5941

# Conflicts:
#	src/components/chips/chips.spec.js
@Splaktar Splaktar removed this from the - Backlog milestone Feb 27, 2018
@Splaktar Splaktar added this to the 1.1.1 milestone Feb 27, 2018
@Splaktar Splaktar added resolution: fixed and removed pr: merge ready This PR is ready for a caretaker to review labels Feb 27, 2018
@Splaktar Splaktar modified the milestones: 1.1.1, 1.1.0 Feb 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P4: minor Minor issues. May not be fixed without community contributions. resolution: fixed
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

fix(chips): fix chips focus functionality devversion/material
6 participants
@topherfangio @ThomasBurleson @shantanu1227 @Splaktar @devversion @a2bsoftware