This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Many Select / Menu Fixes #6151
Closed
Many Select / Menu Fixes #6151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| } | ||
| }; | ||
|
|
||
| MenuItemController.prototype.clearNgAria = function() { |
There was a problem hiding this comment.
Could use a comment here explaining what ngAria does and why it's a problem. (which is my understanding of what's happening here)
|
Overall LGTM aside from minor nitpicks |
ThomasBurleson
added
the
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes many of the issues introduced by the side-effects caused by the accessibility enhancements in RC6, as well as some issues that came to light while debugging the issues reported in RC6.
Fixes an issue where menu contents could go behind the menubar if menu's position was clamped (@jelbourn saw this as the "cropping" issue we experienced while debugging accessibility) (089e33b)
Fix menubar breaking after a menu has been opened and closed with keyboard controls. The first open works as intended, but the following one will break. (d034e14)
Fix placing open selects and menus inside their parent selects. They are now moved to the
bodyelement when they are opened. This resolves positioning inside of dialogs, toolbars, etc. (2ea692b, cd75b22)Fix accessibility issues for menubar menus. Turns out
ngAriawas setting a bunch of aria-related attributes because of ourmd-menu-itemhaving angModelbinding. This could lead to weird situations such as a menuitemcheckbox inside of arole=checkbox. This is now resolved and tested in Chrome w/ NVDA. (9fe3a57) @jelbourn if you can please test w/ Firefox / JAWS