Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(input): Fix input errors CSS to properly display. #6298

Closed
wants to merge 1 commit into from

Conversation

topherfangio
Copy link
Contributor

Due to a CSS property that was not restrictive enough, standard error messages were hidden by default.

Restrict CSS to components with the md-auto-hide class. Note that this unfortunately re-introduces the message flicker bug for messages which do not use the md-auto-hide. This should be fixed when angular/angular.js#12969 is merged and available.

Also, remove the md-maxlength requirement from the errors Hourly Rate demo to reduce confusion.

Fixes #5837. References #5321.

Due to a CSS property that was not restrictive enough, standard
error messages were hidden by default.

Restrict CSS to components with the `md-auto-hide` class.

Also, remove the `md-maxlength` requirement from the errors demo
to reduce confusion.

Fixes #5837. References #5321.
@topherfangio topherfangio added the needs: review This PR is waiting on review from the team label Dec 14, 2015
@topherfangio topherfangio added this to the 1.0-rc8 milestone Dec 14, 2015
@michaelkrog
Copy link

Does this also fix the autocomplete issues?
#5837 (comment)

@topherfangio
Copy link
Contributor Author

@michaelkrog If your issue was specific to the CSS, then this should fix it as well. However, I updated your Codepen to use my local branch and it doesn't look like the messages are even in the DOM.

Can you take a quick look at your Codepen (http://codepen.io/anon/pen/yeLPVy) and see if it's missing something that you can easily fix? I'd love to test this against the Autocomplete and make sure it works.

@michaelkrog
Copy link

Hi @topherfangio.

Something definitely changed in autocomplete. It used to be in the DOM in rc6, but broken because of CSS. Now it seems to be found nowhere i the DOM.

I'll create an issue for it.

@topherfangio topherfangio deleted the team/topher/fix-errors-display-5837 branch December 17, 2015 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: review This PR is waiting on review from the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngMessage not showing until form is touched
3 participants