Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

FAB Speed Dial shows action buttons when ng-hide=true #6331

Closed
doobix opened this issue Dec 16, 2015 · 6 comments
Closed

FAB Speed Dial shows action buttons when ng-hide=true #6331

doobix opened this issue Dec 16, 2015 · 6 comments
Assignees
Labels
needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P4: minor Minor issues. May not be fixed without community contributions. type: bug
Milestone

Comments

@doobix
Copy link

doobix commented Dec 16, 2015

When ng-hide is true for md-fab-speed-dial, the red FAB button goes away, however the white button(s) are visible. This only happens when class is md-fling, no problems with md-scale. Angular material v1.0.0.

screen shot 2015-12-15 at 5 41 49 pm

@topherfangio
Copy link
Contributor

Can you please provide a demo that reproduces this? Just using the default demo and adding ng-hide="true" to the speed dial, I can't seem to recreate it.

@topherfangio topherfangio added the needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue label Dec 16, 2015
@topherfangio topherfangio self-assigned this Dec 16, 2015
@doobix
Copy link
Author

doobix commented Dec 16, 2015

The <md-fab-speed-dial> needs to have class md-fling to see the bug, class md-scale has no problems.

Here's an edited pen of the speed dial demo:
http://codepen.io/anon/pen/Nxxoyx

The white action circle on the right side shows up when self.hidden = true.

@topherfangio
Copy link
Contributor

Thanks for the demo. There's actually two issues here:

  1. The demo has some special CSS that hides the fab trigger, but is causing issues with the action items. If you remove this special CSS, the buttons are properly hidden.
  2. However, this introduces another issue which is that if the speed dial is initially hidden, the animations are never firing which causes it to not open/close properly. This is described here: md-fab-speed-dial showing actions when isOpen is false. #6111 (comment)

I honestly haven't found a quick fix for this, so I will need to continue to investigate.

@topherfangio topherfangio added type: bug needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community priority: high and removed needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue labels Dec 16, 2015
@topherfangio topherfangio added this to the 1.01 milestone Dec 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.1, 1.0.2 Jan 5, 2016
@ThomasBurleson ThomasBurleson added P4: minor Minor issues. May not be fixed without community contributions. and removed priority: high labels Jan 13, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.2, Backlog Jan 15, 2016
@topherfangio
Copy link
Contributor

Dev Note: Should consider watching for $md-resize broadcast.

@zanemcca
Copy link

I have a similar issue except it is due to my trigger button having a clear background. So in the image below the plus icon is the trigger button and as you can see all of the action buttons are visible behind it.

screen shot 2016-04-11 at 5 14 45 pm

This is a regression as it was working fine for me in v0.11.4.

@ThomasBurleson ThomasBurleson modified the milestones: - Backlog, Deprecated Apr 26, 2016
@ThomasBurleson
Copy link
Contributor

This issue is closed as part of our deprecation effort.
For details, see our post Spring Cleaning 2016.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P4: minor Minor issues. May not be fixed without community contributions. type: bug
Projects
None yet
Development

No branches or pull requests

4 participants