Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

select(multiple): adding one resets pristine to true #6556

Closed
Gbacc opened this issue Jan 6, 2016 · 2 comments
Closed

select(multiple): adding one resets pristine to true #6556

Gbacc opened this issue Jan 6, 2016 · 2 comments
Labels
resolution: fixed severity: regression This issue is related to a regression type: bug
Milestone

Comments

@Gbacc
Copy link

Gbacc commented Jan 6, 2016

Ok this is my first message here.

Using lastest version of angularjs/material , it seems i found out an issue using md-select.

See this jsfiddle : http://jsfiddle.net/ypjgdzxp/3/

What you can see here is that i'm adding rows on the fly wich contains an md-select. The problem is that adding a new md-select to the Dom resets the form pristine to true , even if it was false/dirty before.
In my exemple , juste put anything in the upper input "Nom de couche" wich will make the form dirty , then add a new row using the "+" button at the bottom.

@ThomasBurleson ThomasBurleson added this to the Backlog milestone Jan 13, 2016
devversion added a commit to devversion/material that referenced this issue Jan 20, 2016
@devversion
Copy link
Member

Hello, just got into this.

At the first, after querying the git logs I found the commit. which introduced the issue. See 09bd5a3

I created a PR which fixes that #6782

devversion added a commit to devversion/material that referenced this issue Jan 30, 2016
ThomasBurleson pushed a commit that referenced this issue Jan 31, 2016
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this issue Feb 9, 2016
@cstephe
Copy link
Contributor

cstephe commented Oct 17, 2018

I'm a bit confused on this, the commit which keeps being referenced as a fix is actually the cause of the issue, it attempts to fix the issue by causing a side effect on the form. It tries to mitigate the side effect by making a bad assumption that adding to a form with a value set at creation means the form should be clean. Which maybe a 50%+ case for uses but I think there is a very large gap of use cases which this is very bad.

@Splaktar Splaktar changed the title Multiple md-select , adding one resets pristine to true select(multiple): adding one resets pristine to true Oct 25, 2018
@Splaktar Splaktar modified the milestones: - Backlog, 1.1.0 Oct 25, 2018
@Splaktar Splaktar added resolution: fixed severity: regression This issue is related to a regression labels Oct 25, 2018
@angular angular locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolution: fixed severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

No branches or pull requests

5 participants