This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(interim-element): cancel was emitted as list and not as stack #7053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cancel called shift which slices the first element in the Array instead of pop who take the last and also happens on `hide` fixes #6912
EladBezalel
force-pushed
the
fix/interim-stack-cancel
branch
from
1339ad0
to
5d2a6ce
Compare
ThomasBurleson
removed
the
needs: review
ThomasBurleson
added
the
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hidefixes #6912