Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-sidenav: using md-theme does not set CSS class on sidenav element #7084

Closed
oemmes opened this issue Feb 9, 2016 · 1 comment
Closed

md-sidenav: using md-theme does not set CSS class on sidenav element #7084

oemmes opened this issue Feb 9, 2016 · 1 comment
Assignees
@devversion
Labels
pr: merge ready This PR is ready for a caretaker to review
Milestone
1.0.6

Comments

@oemmes
Copy link

oemmes commented Feb 9, 2016

When a theme is defined on a sidebar element the CSS class is not set on that element.

<md-sidenav md-theme="dark"></md-sidenav>
should result in
<md-sidenav md-theme="dark" class="md-dark-theme"></md-sidenav>

Though the class is set on the (automatically generated) backdrop element, the class is not set on <md-sidenav> itself.

As there is the selector md-sidenav.md-THEME_NAME-theme in sidenav-theme.scss I think the class should be automatically assigned to the sidebar element, too.

Codepen: http://codepen.io/anon/pen/YwRjNb
Angular Material version: 1.0.5
@ThomasBurleson ThomasBurleson modified the milestone: 1.0.6 Feb 24, 2016
devversion added a commit to devversion/material that referenced this issue Mar 2, 2016
@devversion
fix(sidenav): apply theming on sidenav correctly
a79c0b2 
- The current theming of the sidenav wasn't working, because theming wasn't initialized on the element.
- Backdrop should only inherit the theme if there is a parent (just a performance improvement - remove end-less non-sense watcher)

Fixes angular#7084
@devversion devversion mentioned this issue Mar 2, 2016
Closed
@devversion
Copy link
Member

@oemmes Nice catch 👍 - definitely an issue - Fixed in #7374

@devversion devversion added the pr: merge ready This PR is ready for a caretaker to review label Mar 2, 2016
ThomasBurleson pushed a commit that referenced this issue Mar 2, 2016
@devversion @ThomasBurleson
fix(sidenav): apply theming on sidenav correctly
035626b 
- The current theming of the sidenav wasn't working, because theming wasn't initialized on the element.
- Backdrop should only inherit the theme if there is a parent (just a performance improvement - remove end-less non-sense watcher)

Fixes #7084

  Closes #7374
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.0.6
Development

No branches or pull requests
3 participants
@ThomasBurleson @devversion @oemmes