This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(dialog): add default value to prompt preset. #7090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -521,7 +522,8 @@ function MdDialogProvider($$interimElementProvider) { | |||
| ' <p>{{::dialog.mdTextContent}}</p>', | |||
| ' </div>', | |||
| ' <md-input-container md-no-float ng-if="::dialog.$type == \'prompt\'" class="md-prompt-input-container">', | |||
There was a problem hiding this comment.
@devversion should this be changed to === instead of == while you're in the area?
PR looks good, thanks for doing this.
There was a problem hiding this comment.
@zbjornson The IDE's and Linters are throwing a warning when using that.
devversion
added
the
needs: rebase
devversion
force-pushed
the
feat/dialog-prompt-defaultvalue
branch
from
df9091e
to
09d1765
Compare
devversion
added
needs: review
| @@ -383,6 +383,7 @@ function MdDialogDirective($$rAF, $mdTheming, $mdDialog) { | |||
| * - $mdDialogPreset#title(string) - Sets the prompt title. | |||
| * - $mdDialogPreset#textContent(string) - Sets the prompt message. | |||
| * - $mdDialogPreset#htmlContent(string) - Sets the prompt message as HTML. Requires ngSanitize | |||
| * - $mdDialogPreset#defaultValue(string) - Sets the default value for the prompt input. | |||
There was a problem hiding this comment.
wrong position, you accidentally spliced the line above
devversion
force-pushed
the
feat/dialog-prompt-defaultvalue
branch
from
09d1765
to
f4c9822
Compare
| @@ -503,7 +504,7 @@ function MdDialogProvider($$interimElementProvider) { | |||
| options: advancedDialogOptions | |||
| }) | |||
| .addPreset('prompt', { | |||
| methods: ['title', 'htmlContent', 'textContent', 'content', 'placeholder', 'ariaLabel', | |||
| methods: ['title', 'htmlContent', 'textContent', 'defaultValue', 'content', 'placeholder', 'ariaLabel', | |||
There was a problem hiding this comment.
I think initialValue is a better name.
There was a problem hiding this comment.
I respected the window.prompt reference here.
There was a problem hiding this comment.
@ThomasBurleson Finally updated. Sorry for the delay ;)
ThomasBurleson
added
needs: work
in progress
devversion
force-pushed
the
feat/dialog-prompt-defaultvalue
branch
from
f4c9822
to
c3bb7e0
Compare
devversion
added
needs: review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7046