This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(dialog): correctly disable keydown listener for escapeToClose #7222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there was a duplicated variable `target`, which got replaced later and the `target` variable became the actual `element` not the `parent` anymore. Fixes angular#7214 Fixes angular#5153
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there was a duplicated variable
target, which got replaced after some execution and the actualtargetvariable became assigned to theelementvariable, not to theparentanymore.That's caused because in JS there is no block scope, only function scope.
Fixes #7214 Fixes #5153