This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(progress-circular): removed dependency on ng-hide class
#7460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the progress mode wasn't indeterminate or determinate it would use `ng-hide` class to hide it, and if it's a valid mode, `ng-hide` was removed, what caused `ng-hide` not to preform as wanted. Now when mode is not indeterminate or determinate set it default to indeterminate fixes #7454
|
@EladBezalel You need to update the demo too, because it uses |
|
@EladBezalel - much better logic here. Thx. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng-hideclass to hide it, and if it's a valid mode,ng-hidewas removed, what causedng-hidenot to preform as wanted.Now when mode is not indeterminate or determinate set it default to indeterminate
fixes #7454