Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

ng-click on md-list-item not triggered in Firefox #7490

Closed
cgx opened this issue Mar 9, 2016 · 4 comments
Closed

ng-click on md-list-item not triggered in Firefox #7490

cgx opened this issue Mar 9, 2016 · 4 comments
Assignees
Labels
pr: merge ready This PR is ready for a caretaker to review

Comments

@cgx
Copy link
Contributor

cgx commented Mar 9, 2016

When defining an ng-click on a md-list-item, the action is never triggered in Firefox (tested with version 45).

Explicitly using a md-button inside a md-list-item is a workaround, but requires to use the now private underscore classes.

Test available on codepen.

@gpopovic
Copy link

+1

@devversion devversion self-assigned this Mar 10, 2016
devversion added a commit to devversion/material that referenced this issue Mar 10, 2016
I recently fixed a issue with the firefox click, and it worked perfectly. But in another commit later I unintentionally *removed* the firefox fix. So this fix reintroduces the fix and made it compatible with the other list fixes.

In additon to that, this commit fixes the text overflow for multiline items with ng-click.

Fixes angular#7490 Fixes angular#7499
@devversion devversion added the pr: merge ready This PR is ready for a caretaker to review label Mar 10, 2016
@christiaanwesterbeek
Copy link

christiaanwesterbeek commented Sep 29, 2016

Looks like this problem got re-introduced with Material 1.1.1

This is 1.0.9:
image
This is 1.1.1
image

I can't click the items in de list or at least the method defined with ng-click is not called with 1.1.1

This time however the problem is with both Chrome and Firefox.

Update: I don't seem to be able to reproduce the problem I'm having it in this fiddle: https://jsfiddle.net/devotis/xwjypL6y/
Weird part is that I can definitely reproduce it in my app where at some point the only change is that I upgrade Material from 1.0.9 tot 1.1.1 and Angular from 1.5.7 to 1.5.8...

@devversion Does the problem I'm having seem familiair to you?

Update 2: Forget about it. There was custom css adding position: relative to this md-list-item-inner that caused the problem. Leaving this comment here in the off-chance that anybody else encounters the same problem.

@ScoobyTchotchke
Copy link

+1

@christiaanwesterbeek
Copy link

@sjmiller85 You're +1-ing a closed issue. Do you have a test case or does the codepen previously provided actually produce the bug for you?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants