Fix(select): layout issue

[david-meza]

• Make selector less aggressive restricting it to the text span only
• Add a max width, so the overflow rule will go in effect if we reach the width of the container
• Allow span to shrink if width is greater than that of the input container

Closes #6200 and #6312

[david-meza]

Can you also check I did the git procedure correctly? I don't think you want the merge with master message, but not entirely sure how to remove it. Do I just do git rebase <my-branch-name>?

[ThomasBurleson]

@topherfangio - can you review plz

[topherfangio]

@david-meza Thanks for this PR! The code looks good to me, but can you squash your commits as outlined here: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Make sure to pick the first commit and squash the "Merged ..." commit.

The commands you run should look something like:

git checkout master
git pull upstream master --rebase
git checkout fix/select-layout-issue
git rebase -i master
git push --force

Note that the force push will only update the branch you are on, so make sure you're still on the fix/select-layout-issue branch when you run it. That should update this PR with a single commit.

Let me know if you have questions!

[david-meza]

Thanks! That was helpful. Only got a bit confused because there's no --rebase option for pulling but eventually got it working.

[ThomasBurleson]

Why is this nested under & > span:not(._md-select-icon) ?
What is the use case ?

[david-meza]

That is a great question @ThomasBurleson . Sorry your comment got deleted in the rebase. Basically the reason why it was nested is because you should apply those rules to the element that actually contains the text, otherwise the parent would hide the overflow, but not apply the text-overflow rule. However, I later noticed that ._md-text had an inline display, so this rule should make the span have the behavior you want (because the div loses it's default block display, thus making the text being part of the span)

[ThomasBurleson]

@topherfangio - please review