Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

progress-circular: theming not working probably. #7570

Closed
HBO2 opened this issue Mar 15, 2016 · 3 comments
Closed

progress-circular: theming not working probably. #7570

HBO2 opened this issue Mar 15, 2016 · 3 comments
Assignees
@crisbeto

Comments

@HBO2
Copy link

HBO2 commented Mar 15, 2016

Hi,

I have checked the master and I noticed all the theming issues are solved. Only the md-progress-circular is stilling a little out of order by using the default blue rgb color indicating the theme is not set for the md-progress-circular. Also the adapted size in my theme size seems to be ignored.

Thanks
@crisbeto
Copy link
Member

I'll take a look at the theming, but what do you mean about the size? The size on the progressCircular will definitely be different from before since the old implementation wasn't completely accurate (e.g. if you specified 50px, it would render around 30px).

@crisbeto crisbeto self-assigned this Mar 15, 2016
@devversion devversion changed the title theming not fixed for 100% progress-circular: theming not working probably. Mar 15, 2016
crisbeto added a commit to crisbeto/material that referenced this issue Mar 15, 2016
@crisbeto
fix(progress-circular): add theming, simplify demo
09c5180 
* Applies `$mdTheming` to the `progressCircular` component.
* Simplifies the `progressCircular` demo.

Closes angular#7570.
@crisbeto crisbeto mentioned this issue Mar 15, 2016
Closed
crisbeto added a commit to crisbeto/material that referenced this issue Mar 15, 2016
@crisbeto
fix(progress-circular): add theming, simplify demo
8850b10 
* Applies `$mdTheming` to the `progressCircular` component.
* Simplifies the `progressCircular` demo and adds an example of the dark theme colors.
* Removes strict dependency injection in the `progressCircularDirective`.

Closes angular#7570.
@mpiasta-ca
Copy link

I'm trying to setup md-progress-circular right now (using 1.0.6). When I set md-diameter="100px", the width and height box on the element is 100px. But the actual spinning circle is only 50px in diameter, resulting in huge empty space around the spinning circle inside of its container.

I think 1.1.0-RC might fix it, but looks like that's still not available on bower.

@ThomasBurleson
Copy link
Contributor

@mpiasta-ca -
1.1.0-rc1 is available on Bower
I recommend you use the latest on bower-material/master with the

# To get the most recent, last committed-to-master version use:
bower install angular-material#master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ThomasBurleson @mpiasta-ca @crisbeto @HBO2