This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): don't show the loading bar when hitting escape on an empty input #7934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -618,7 +618,7 @@ function MdAutocompleteCtrl ($scope, $element, $mdUtil, $mdConstant, $mdTheming, | |||
| // Set the loading to true so we don't see flashes of content. | |||
| // The flashing will only occour when an async request is running. | |||
| // So the loading process will stop when the results had been retrieved. | |||
| setLoading(true); | |||
| if ($scope.searchText) setLoading(true); | |||
There was a problem hiding this comment.
I think, since the clear button is hidden, when the search text is empty, the autocomplete should not call clearValue() when pressing ESC as well.
There was a problem hiding this comment.
That works too, thanks for the input.
…an empty input The loading bar was being shown if the user pressed escape on an empty autocomplete input. Closes angular#7927.
crisbeto
force-pushed
the
fix/autocomplete-progress
branch
from
a579c8e
to
d2d3fee
Compare
|
LGTM now. |
devversion
added
pr: merge ready
ilovett
pushed a commit
to ilovett/material
that referenced
this pull request
Apr 22, 2016
…an empty input The loading bar was being shown if the user pressed escape on an empty autocomplete input. Closes angular#7927. Closes angular#7934
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loading bar was being shown if the user pressed escape on an empty autocomplete input.
Closes #7927.