Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-colors: not accepting color differentiating names (hue-1, etc) #8175

Closed
evankoffler opened this issue Apr 22, 2016 · 1 comment
Closed

md-colors: not accepting color differentiating names (hue-1, etc) #8175

evankoffler opened this issue Apr 22, 2016 · 1 comment
Assignees
@EladBezalel
Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. ui: theme
Milestone
1.1.0

Comments

@evankoffler
Copy link

md-colors has the flexibility to specify the shade color directly which is nice for ultimate control.

However, it does not allow the use of the hue-1, hue-2, hue-3 in any form (hue1 or hue-1) to specify the shade to use. This means that it is difficult to style non-md elements via md-colors since one has to specify the shade value and realize the relationship between the name and its underlying actual value such as for primary hue-1 is 300. Plus if the hue was changed via the $mdThemingProvider, then it would not reflect this.

Example at: http://codepen.io/anon/pen/VaBMNM
@ThomasBurleson
Copy link
Contributor

@EladBezalel - your thoughts? If not valid, please close.

@ThomasBurleson ThomasBurleson added this to the - Backlog milestone Apr 22, 2016
@EladBezalel EladBezalel added needs: team discussion This issue requires a decision from the team before moving forward. P4: minor Minor issues. May not be fixed without community contributions. and removed needs: team discussion This issue requires a decision from the team before moving forward. labels Apr 23, 2016
@EladBezalel EladBezalel modified the milestones: 1.1.0, - Backlog Apr 25, 2016
EladBezalel added a commit that referenced this issue Apr 28, 2016
@EladBezalel
feat(colors): support hue-x on primary/accent/warn/background palettes
b580101 
- Added hue-x support e.g '{background: 'primary-hue-2-0.3'}'

fixes #8175
EladBezalel added a commit that referenced this issue Apr 28, 2016
@EladBezalel
feat(colors): support hue-x on primary/accent/warn/background palettes
2f9a3c6 
- Added hue-x support e.g '{background: 'primary-hue-2-0.3'}'

fixes #8175
@EladBezalel EladBezalel mentioned this issue Apr 28, 2016
Closed
@EladBezalel EladBezalel added the has: Pull Request A PR has been created to address this issue label Apr 28, 2016
EladBezalel added a commit that referenced this issue May 10, 2016
@EladBezalel
feat(colors): support hue-x on primary/accent/warn/background palettes
edb653e 
- Added hue-x support e.g '{background: 'primary-hue-2-0.3'}'

fixes #8175
EladBezalel added a commit that referenced this issue May 11, 2016
@EladBezalel
feat(colors): support hue-x on primary/accent/warn/background palettes
3265a8f 
- Added hue-x support e.g '{background: 'primary-hue-2-0.3'}'

fixes #8175
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EladBezalel EladBezalel

Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. ui: theme
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

feat(colors): support hue-x on primary/accent/warn/background palettes angular/material
3 participants
@ThomasBurleson @evankoffler @EladBezalel