fix(input): add support for dynamically loaded ngMessage directives. #8387
Conversation
devversion
force-pushed
the
fix/input-message-fragment
branch
from
befb1c4
to
f701272
Compare
* Currently ngMessage directives inside of an input-container, which are loaded / transcluded dynamically, didn't get initialized properly. The animation was not working. As well as the auto-hide didn't work properly. Fixes angular#7477. Fixes angular#7596. Fixes angular#6810. Fixes angular#7823
devversion
force-pushed
the
fix/input-message-fragment
branch
from
f701272
to
758ea6c
Compare
|
@topherfangio Added the tests as discussed :) |
| expect(ngMessage).toHaveClass('md-input-message-animation'); | ||
| })); | ||
|
|
||
| it('should set the animation class on a transcluded ngMessage', function() { |
There was a problem hiding this comment.
I'm curious if we could do a different/shorter test here.
Based on the issues this is supposed to fix, if we put it inside an autocomplete, or use the ng-messages-include directive, it would fail correct (I mean, without this PR)?
Is there a reason to do it as a document fragment test rather than one of the standard transclusion methods listed in the issues?
There was a problem hiding this comment.
Actually, as I commented on the test, using the document fragment is testing the new added code in the input component.
Using a tranclusion here and testing it, would be more complicated.
I will give it a try with the ng-messages-include.
There was a problem hiding this comment.
Okay, if that's the case, then go ahead and add the ng-messages-include as a separate test if you can 😄
Thanks for the clarification!
The animation was not working. As well as the auto-hide didn't work properly.
cc. @topherfangio
Fixes #7477. Fixes #7596. Fixes #6810. Fixes #7823