This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(toolbar): fix the toolbar not shrinking on load #8543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function that updates the toolbar height was firing too early, which caused the shrinking functionality not to work until 5sec after the last scroll event. This commit fixes it by waiting until the first digest before initializing the toolbar height. Fixes angular#8258, angular#8221.
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function that updates the toolbar height was firing too early, which caused the shrinking functionality not to work until 5sec after the last scroll event. This commit fixes it by waiting until the first digest before initializing the toolbar height.
Fixes #8258, #8221.