Wip sub header #268
Wip sub header #268
Conversation
Correcting dates. This project is only from 2014.
rschmukler
force-pushed
the
wip-sub-header
branch
from
eee175b
to
1e9e15f
Compare
|
This pull request got all sorts of weird when I rebased my changes on top of master... |
|
@ryan can you try rebasing again? You accidentally force-pushed your old version of master up yesterday when doing some rebasing. I force-pushed my newer version of master back over the one you pushed and all is well now. If you rebase again it may all work correctly. |
| $el.css({position: browserStickySupport, top: '0px'}); | ||
| } | ||
|
|
||
| var debouncedCheck = $container.data('$stickyCheck') || $$rAF.debounce(checkElements.bind(undefined, $container)); |
There was a problem hiding this comment.
Better to use angular.bind(context, fn, args) here. Function.prototype.bind doesn't exist on android 2.x. Although we don't actually support android 2, I would rather have a way to gracefully show an error on 2.x devices rather than just have the app completely stop due to a simple error like this one.
| (function findTargetElement() { | ||
| var scroll = $container.scrollTop(); | ||
| for(var i = 0; i < orderedElements.length ; ++i) { | ||
| if(rect(orderedElements[i].children(0)).bottom > 0) { |
There was a problem hiding this comment.
What's the point of .children(0) here?
This implements #216.
As per suggestion from @matsko, uses native
position: stickywhen possible, otherwise uses a javascript implementation using the new$materialStickyservice.A new directive
material-stickyis also exposed, which uses the$materialStickyservice.This pull request also makes the
material-subheadercreate ah2for accessibility purposes as per @marcysutton's suggestion. Subsequently, it ups theh2andh3inmaterial-list-itemtoh3andh4respectively.Commit messages will be squashed when approved by the team. Figured it'd be easier to see how it was implemented with individual commits.
Would love suggestions from @ajoslin on ideas for testing
$materialStickyservice, or anyone else who has ideas.Also does anyone have opinion on whether we want to document
material-stickydirective /$materialStickyservice for usage on the docs?