This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(material-radio): Radio button a11y #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcysutton
force-pushed
the
radio-a11y-refactor
branch
2 times, most recently
from
6c801e4
to
ee2276c
Compare
| @@ -53,7 +53,7 @@ function materialRadioGroupDirective() { | |||
|
|
|||
| return { | |||
| restrict: 'E', | |||
| controller: RadioGroupController, | |||
| controller: ['$element', RadioGroupController], | |||
marcysutton
force-pushed
the
radio-a11y-refactor
branch
from
ee2276c
to
d2e5414
Compare
marcysutton
force-pushed
the
radio-a11y-refactor
branch
from
d2e5414
to
8d67f50
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves accessibility of
material-radio-groupby addingaria-activedescendantwith the activematerial-radio-button's id. If the radio button doesn't already have an ID, one is generated and injected dynamically.Closes #310