Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

feat(input): allow skip hidden inputs #6425

Closed
wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

inputs with type hidden will be skipped by the input-container

breaking

fixes #2153

@topherfangio
Copy link
Contributor

I think this warrants a note in the docs about how we skip inputs. Otherwise, LGTM.

@devversion
Copy link
Member Author

@topherfangio - I added a note to the <md-input-container> directive. Is that note enough?

PS: CI is still failing due Karma (will be fixed in [email protected])

@topherfangio
Copy link
Contributor

Let's change the wording to this:

A single <md-input-container> should contain only one <input> element, otherwise it will throw an error.

Exception: Hidden inputs (<input type="hidden" />) are ignored and will not throw an error, so
you may combine these with other inputs.

@devversion devversion force-pushed the feat/input-hidden-skip branch 2 times, most recently from 3bad9a8 to 9bfbd0d Compare January 5, 2016 14:50
@devversion
Copy link
Member Author

If I got your new wording right (with the divider and so on), it should look like this? (bold exception seems to be smaller as the actual text is).

Still needs work? @topherfangio

@ThomasBurleson ThomasBurleson added P1: urgent Urgent issues that should be addressed in the next minor or patch release. and removed P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Jan 15, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.0, Backlog Jan 15, 2016
@devversion
Copy link
Member Author

@topherfangio - Can you review the documentation message?

@topherfangio topherfangio added pr: merge ready This PR is ready for a caretaker to review and removed needs: work labels Jan 27, 2016
@topherfangio
Copy link
Contributor

@ThomasBurleson LGTM; not sure which milestone you want this in. Can you please take a look?

@topherfangio topherfangio modified the milestones: 1.1.0, Backlog Feb 4, 2016
@topherfangio topherfangio added - Breaking Change needs: work and removed pr: merge ready This PR is ready for a caretaker to review labels Feb 4, 2016
@topherfangio
Copy link
Contributor

I'm going to go ahead and delay this until 1.1.0 as it could affect some of our existing users.

@devversion Can you please amend the commit message with a BREAKING CHANGE note about how we now skip inputs. We do it in the commit message because our Changelog process automatically pulls from there when noting breaking changes.

BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container`

Fixes angular#2153
@devversion
Copy link
Member Author

@topherfangio Done - Just updated the PR description too, so you can see it there.

@topherfangio topherfangio added pr: merge ready This PR is ready for a caretaker to review and removed needs: work labels Feb 4, 2016
ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container`

Fixes #2153

Closes #6425
ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container`

Fixes #2153

Closes #6425
gmoothart pushed a commit to gmoothart/material that referenced this pull request Apr 5, 2016
BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container`

Fixes angular#2153

Closes angular#6425
@devversion devversion deleted the feat/input-hidden-skip branch April 21, 2016 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
- Breaking Change P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-input-container should ignore hidden fields as part of the inputs its counting.
3 participants