feat(whiteframe): add directive to apply md-whiteframe classes #6831
Conversation
| var elevation = attr.mdWhiteframe || DEFAULT_DP; | ||
|
|
||
| if (elevation > MAX_DP || elevation < MIN_DP) { | ||
| $log.warn('md-whiteframe attribute value is invalid. It should be a number between ' + MIN_DP + ' and ' + MAX_DP, element[0]); |
There was a problem hiding this comment.
This needs to be improved?
|
What about the |
devversion
force-pushed
the
feat/whiteframe-directive
branch
from
75364fe
to
594c0d8
Compare
|
That's not said in #6772. But they still can be accessed through the |
devversion
force-pushed
the
feat/whiteframe-directive
branch
from
594c0d8
to
c16dacd
Compare
|
I understand DevVersion. When checking older issues I have found that the Maybe it would be a good time to remove the |
| * @restrict A | ||
| * | ||
| * @description | ||
| * The md-whiteframe directive allows you to apply an elevation shadow to a element. |
|
Besides the comments LGTM, @devversion thanks for helping me cleaning my queue :) |
devversion
force-pushed
the
feat/whiteframe-directive
branch
from
c16dacd
to
8fda58c
Compare
|
@EladBezalel Any time again :) - Applied the suggestions 😄 |
| @@ -0,0 +1,45 @@ | |||
| div[md-whiteframe] { | |||
There was a problem hiding this comment.
- Attribute selectors are slow in IE.
- This limits the use of
md-whiteframeto divs ONLY. Should bemd-white-frame
There was a problem hiding this comment.
I thought I should use a div here, as shown in #6772
There was a problem hiding this comment.
I don't know how i missed it, you DON'T want to restrict the use to use only div
There was a problem hiding this comment.
Already updated. Just was confused from the description. Sorry.
PS: This is only the demo, it won't restrict the actual use of the md-whiteframe directive.
ThomasBurleson
added
needs: work
and removed
needs: review
devversion
force-pushed
the
feat/whiteframe-directive
branch
from
8fda58c
to
a9a5e01
Compare
|
@ThomasBurleson - Added the missing |
…classes `md-whiteframe` can now be used as a class or a directive attribute. Fixes angular#6772, closes angular#6831.
@EladBezalel You got assigned for this issue, but everywhere is anyone assigned so I just did that PR. If you had a PR in progress, let me know :)
Fixes #6772