This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(layout): resolve issues with IE and calc() in flexbox #6898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE has issues with `calc()` usages in flex styles; replace with 33.33% and 66.66%.
|
@topherfangio - can you review ? |
ThomasBurleson
added
the
needs: review
|
@ThomasBurleson LGTM - Do you recall why you changed it to |
|
@topherfangio - previously (1.0.2), the setting was flex : 1 1 33%
flex : 1 1 66%these were not precise enough (leaving a potential 1% gap) flex: 1 1 calc(100% / 3)
flex: 1 1 calc(200% / 3)would resolve that, but has issues in IE. So the compromise is: flex: 1 1 33.33%;
flex: 1 1 66.66%; |
ThomasBurleson
added
pr: merge ready
|
Gotcha. Sounds good to me :-) |
ThomasBurleson
added
the
P0: critical
ErinCoughlan
pushed a commit
to ErinCoughlan/material
that referenced
this pull request
Feb 9, 2016
IE has issues with `calc()` usages in flex styles; replace with 33.33% and 66.66%. Closes angular#6898
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6849.