Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider entire hierarchy of tsconfig jsons #2085

Open
1 of 2 tasks
MatteoPiovanelli-Laser opened this issue Sep 10, 2024 · 0 comments
Open
1 of 2 tasks

consider entire hierarchy of tsconfig jsons #2085

MatteoPiovanelli-Laser opened this issue Sep 10, 2024 · 0 comments
Labels

Comments

@MatteoPiovanelli-Laser
Copy link

Is your feature request related to a problem? Please describe.

🚀 feature request

Description

Currently the VS Code plugin doesn't seem to take into account the tsconfig.lib.json file for a library.

I'm working on an Angular workspace that contains libraries and applications. The plugin seems to be "using" only the workspace's tsconfig.json file.
For example, if I add "useDefineForClassFields": false in tsconfig.lib.json for a library, that library builds correctly, but while editing files VS Code underlines some stuff as errors:
image
If I move that "useDefineForClassFields": false to the tsconfig.json file for the whole workspace that error disappears (and the library still builds the same).
In this workspace we have several libraries: some are older code we are updating; some are templates we are bundling for our reuse. We have a few of these settings that we apply specifically to one library or another (e.g. "paths"), and that we don't want to apply at workspace level. Again, the libraries build correctly, but having the editor report errors differently from the compiler is a big pain, especially for our junior developers.

Feature Type

This is a user-experience bug, for the most part.

  • Angular Language Service VSCode extension
  • Angular Language Service server

Describe the solution you'd like

I guess, since the tsconfig.lib.json contains information on the json file it extends, I would like the VS Code plugin to be loading and merging the files, just like invoking ng build does, so that we'd have correct "intellisense" and highlighting.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?

Anything else relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant