Features/add stream support #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull requests are always welcome. I have used yapf & pep8 for this project.
I'll take a look at the changes this weekend and send you revision comments
if any.
…On Thu, May 21, 2020, 9:39 PM Fabrizio Milo ***@***.***> wrote:
planning on contributing few more patches. It would be useful to have a
standard format.
right now I used the pep8 with yapf and pylintrc (the standard tensorflow
rc).
other patches contain fixes for lazy loading (ie. no fixed .format) and
for loading the datasets from a stream (used in online batch setting).
Let me know if these are welcome and I will try to propose them as I work
on my own repository.
------------------------------
You can view, comment on, or merge this pull request online at:
#58
Commit Summary
- add pylintrc
- pep8 format
- add lazy logging
- add support for stream input
File Changes
- *A* .pylintrc
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-d6d3d73911fd3ad6f39e4027f763b307>
(335)
- *M* deepmatcher/__init__.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-14412b1d0eedb4281cef5fc32991ccb9>
(14)
- *M* deepmatcher/batch.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-ffeb2e4353aa1e9401beed0f4ebcebf5>
(15)
- *M* deepmatcher/data/dataset.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-b7cc7403bf61da55660109f79b1e906e>
(163)
- *M* deepmatcher/data/field.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-53d9c6bcb0ab5f5cc2e2d68952670359>
(4)
- *M* deepmatcher/data/process.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-b426612da60b810fbaaa86a4b31c3461>
(100)
- *M* deepmatcher/models/core.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-dc4736cc373a64387b834114fb4e163f>
(113)
- *M* deepmatcher/models/modules.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-58facc161d8338910bdae6192c7b9a93>
(2)
- *M* deepmatcher/optim.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-932082181b098b45dd1c333b14c3bbc1>
(23)
- *M* deepmatcher/runner.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-3371eb0ff0a8b6a2c48e08f60d5290da>
(126)
- *M* deepmatcher/utils.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-d782166e9e8cb9b14a338b6fcbd78d7d>
(1)
- *M* setup.cfg
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-380c6a8ebbbce17d55d50ef17d3cf906>
(4)
- *M* test/test_dataset.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-79a5d44198dfe123076494fa5ad57c6d>
(161)
- *M* test/test_field.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-8871d8e0f0a956485e30aa471f622d08>
(39)
- *M* test/test_integration.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-67ec2bf00b0a54c0fa8d06ee654230d5>
(172)
- *M* test/test_iterator.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-3a40f1b8ed71a81e731428b9554d561d>
(42)
- *M* test/test_process.py
<https:/anhaidgroup/deepmatcher/pull/58/files#diff-fd18c718241bdc97c60788c6b683c484>
(108)
Patch Links:
- https:/anhaidgroup/deepmatcher/pull/58.patch
- https:/anhaidgroup/deepmatcher/pull/58.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#58>, or unsubscribe
<https:/notifications/unsubscribe-auth/ABWE5ZIYFPNM6GOLY624FMLRSX6X3ANCNFSM4NHPALSA>
.
|
Mistobaan
force-pushed
the
features/add-stream-support
branch
from
0aac300
to
50192cd
Compare
|
It seems using the TF formatting config is causing a lot of changes - probably because of the 80 character limit that Google uses. It's kinda hard to isolate the actual changes in this PR. It would be awesome if you could just have the main changes and keep the formatting as is for the unchanged parts - I believe the default yapf formatting (probably with a line limit of 120) should result in around the same formatting as the code currently has. |
sidharthms
reviewed
Jun 10, 2020
| class CacheStaleException(Exception): | ||
| r"""Raised when the dataset cache is stale and no fallback behavior is specified. | ||
| """ | ||
| pass |
There was a problem hiding this comment.
Why is this line deleted?
sidharthms
reviewed
Jun 10, 2020
|
|
||
| begin = timer() | ||
| dataset_args = {'fields': fields, 'column_naming': column_naming} | ||
| dataset = MatchingDataset(path=path, **dataset_args) | ||
| dataset = MatchingDataset(stream=stream, **dataset_args) |
There was a problem hiding this comment.
Maybe I'm missing something - MatchingDataset does not take "stream" as argument right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
planning on contributing few more patches. It would be useful to have a standard format.
right now I used the pep8 with yapf and pylintrc (the standard tensorflow rc).
other patches contain fixes for lazy loading (ie. no fixed
.format) and for loading the datasets from a stream (used in online batch setting).Let me know if these are welcome and I will try to propose them as I work on my own repository.