Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GH action to check/publish animint book #76

Open
tdhock opened this issue Aug 25, 2022 · 2 comments
Open

add GH action to check/publish animint book #76

tdhock opened this issue Aug 25, 2022 · 2 comments

Comments

@tdhock
Copy link
Collaborator

tdhock commented Aug 25, 2022

these days before merging a PR, I am re-building https:/tdhock/animint-book to make sure nothing breaks.
this suggests we should add a GH action which does this automatically for every push.
For publishing it would be nice to have at least the master branch.

@Faye-yufan
Copy link
Contributor

Hi @tdhock , do you think checking for compilation errors in the GH action is enough? I recall when I worked on the color_off function, most issues from the manual seemed to be related to visual effects, which required a visual inspection. Do you feel there's a need to create tests specifically for these visual effects?

@tdhock
Copy link
Collaborator Author

tdhock commented Aug 11, 2023

you are right it probably will require a manual visual inspection, but it would be useful to have that automatically built and deployed via actions (rather than on my own laptop). hopefully things like color_off should be covered in tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants