Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Auto Releases #317

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Conversation

gabriel-stackhouse
Copy link
Contributor

Summary of changes

Poking around in this repository, I saw your comment in your main workflow file that auto-release creation was broken. Seeing as I have auto-releases working splendidly for my organization, I figured I'd pass along my config if you were interested in using it.

Feel free to change/tweak/adjust whatever you like here, or to reject it entirely. Completely up to you.

Breaking Changes

NO

How changes have been tested

Ran the workflow on my own forked repo with success:

image

List any unknowns

N/A

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 26, 2024

To clarify this we closed as we only release this repo using self action not third party actions.

@anothrNick anothrNick reopened this Jun 27, 2024
@anothrNick
Copy link
Owner

Re-opened as https:/softprops/action-gh-release looks like a better alternative to the archived action we currently use for releases.

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 27, 2024

If we merge as is it won't trigger a release because we are not updating the entrypoint or dockerfile etc.

I would suggest adding a comment somewhere to force a release at merge.

No further comments from me.

@gabriel-stackhouse
Copy link
Contributor Author

Rebased on master, removed the placeholder comments, and threw in a comment to entrypoint.sh to trigger the workflow run. Tested working on my own repo.

Let me know if you have any more concerns or questions.

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 28, 2024

Approved. Not sure why I cannot merge

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 28, 2024

Assuming @anothrNick you changed my permissions?

@anothrNick
Copy link
Owner

I haven't changed your permissions. Maybe because I reopened? Not sure

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 28, 2024

Can @gabriel-stackhouse and or @anothrNick merge this.

@gabriel-stackhouse
Copy link
Contributor Author

@sbe-arg I don't have write permissions to the repo, so I'm also unable to merge.

@anothrNick?

@anothrNick anothrNick merged commit 777684d into anothrNick:master Jul 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants