Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme_account: add support for External Account Binding #100

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes #89.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

acme_account

@felixfontein
Copy link
Contributor Author

ready_for_review

@felixfontein felixfontein mentioned this pull request Aug 9, 2020
@felixfontein
Copy link
Contributor Author

CC @resmo

@felixfontein
Copy link
Contributor Author

Hmmm, I can't get this to work with ZeroSSL's ACME server. I always get

{
  "detail": "The request must include a value for the \"externalAccountBinding\" field",
  "status": 400,
  "type": "urn:ietf:params:acme:error:externalAccountRequired"
}

despite externalAccountBinding being included. I guess their error message is very misleading and they want to say that something else is wrong...

@felixfontein
Copy link
Contributor Author

Ok, I found the "problem": I didn't specify an email during account registration. Once I added an email address, it worked...

Copy link
Member

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein
Copy link
Contributor Author

@resmo I added a bit more code to make sure the module is idempotent with ZeroSSL.

@felixfontein felixfontein merged commit d03e723 into ansible-collections:main Aug 16, 2020
@felixfontein felixfontein deleted the acme-account-exernal-account-binding branch August 16, 2020 16:00
@felixfontein
Copy link
Contributor Author

@resmo thanks a lot for reviewing this one as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

acme_account: add support for External Account Binding
2 participants