Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x509_certificate_info: move main code to module_utils to allow easier implementation of diff mode #206

Merged

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Subset of #150.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

x509_certificate_info

This was referenced Mar 20, 2021
@felixfontein
Copy link
Contributor Author

recheck

Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with same explicit exception suggestions as the previous reviews.

plugins/modules/x509_certificate_info.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@felixfontein felixfontein merged commit ba03580 into ansible-collections:main May 15, 2021
@felixfontein felixfontein deleted the info-certificate-move branch May 15, 2021 20:52
@felixfontein
Copy link
Contributor Author

@Ajpantuso thanks a lot for reviewing this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants