openssh_keypair - Add diff support and general cleanup #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds
diff
support foropenssh_keypair
as well as enhances file overwriting operations to preserve and restore from backup in the event of failure. Also integrates both of theopenssh_*
modules to ensure consistency.ISSUE TYPE
COMPONENT NAME
plugins/modules/openssh_cert.py
plugins/modules/openssh_keypair.py
ADDITIONAL INFORMATION
Fixes some issues for file permissions as well:
ssh-keygen
preserves the original files permissions when overwriting and these changes ensure thecryptography
backend does the same.atomic_move
is replaced withpreserved_copy
when no file exists at the destination to prevent a potentially secure file from being updated with permissions from the parent directory's mask.