openssl_pkcs12: add privatekey_content option #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
pkcs12-key-input
branch
3 times, most recently
from
6b9c083
to
ca01812
Compare
felixfontein
force-pushed
the
pkcs12-key-input
branch
from
ca01812
to
08ad547
Compare
s-hertel
approved these changes
May 9, 2022
briantist
approved these changes
May 9, 2022
|
@s-hertel @briantist thanks a lot for reviewing this! HashiCorp vault is another use-case for this, as is sops. The latter triggered me to do this, since I use sops for my private infrastructure and had to resort to this hack ;-) |
This was referenced May 9, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This allows to store the private key in another form, like in Ansible vault, or encrypted with sops.
Right now it has to be present as a file, which in my setup requires me to write it to a temporary file (unprotected), use it in this module, and then wipe the temporary file in a
always:part of ablock:. That's a lot of extra code and also dangerous.(Not that PKCS12 passphrases offer that much more protection...)
ISSUE TYPE
COMPONENT NAME
openssl_pkcs12