Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action plugin support code: ensure compatibility with newer versions of ansible-core #515

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

felixfontein
Copy link
Contributor

SUMMARY

See ansible/ansible#78860.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/plugin_utils/action_module.py

@felixfontein
Copy link
Contributor Author

I explicitly ran the openssl_privatekey_pipe tests against ansible/ansible#78860 (also ran them once with C.STRING_CONVERSION_ACTION mentioned in the constructor to check that it crashes), and it worked fine.

@felixfontein felixfontein merged commit b3f589d into ansible-collections:main Sep 23, 2022
@patchback
Copy link

patchback bot commented Sep 23, 2022

Backport to stable-1: cherry-pick succeeded

Backport PR branch: patchback/backports/stable-1/b3f589df62d9ead872f02fc10820829ec78d1d75/pr-515

PR branch created, proceeding with making a PR.

🤖 @patchback
I'm built with octomachinery and
my source is open — https:/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the compat branch September 23, 2022 05:02
patchback bot pushed a commit that referenced this pull request Sep 23, 2022
…of ansible-core (#515)

* Only access C.STRING_CONVERSION_ACTION for old ansible-base / Ansible versions.

* Always use self.__xxx instead of xxx directly.

(cherry picked from commit b3f589d)
felixfontein added a commit that referenced this pull request Sep 23, 2022
…of ansible-core (#515) (#516)

* Only access C.STRING_CONVERSION_ACTION for old ansible-base / Ansible versions.

* Always use self.__xxx instead of xxx directly.

(cherry picked from commit b3f589d)

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant