Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acme_ari_info module #732

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Allows to retrieve ACME Renewal Information (https://www.ietf.org/archive/id/draft-ietf-acme-ari-03.html).

ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

acme_ari_info

Copy link

github-actions bot commented Apr 28, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.crypto/branch/main

@felixfontein
Copy link
Contributor Author

felixfontein commented Apr 28, 2024

Currently contains #733.

@felixfontein
Copy link
Contributor Author

I moved code from this PR to #735, #736, #737, and #738, to simplify the remaining code in this PR. My plan is to extend this PR a bit more to provide better functionality.

@felixfontein felixfontein marked this pull request as draft April 29, 2024 21:11
@felixfontein
Copy link
Contributor Author

I've thought more about this. I think it's better to have two modules:

  1. acme_ari_info for retrieving raw ARI information.
  2. acme_renewal_info for determining whether to renew a certificate, based on multiple inputs, including ARI.

@felixfontein felixfontein merged commit 6d4fc58 into ansible-collections:main Apr 30, 2024
142 checks passed
@felixfontein felixfontein deleted the ari branch April 30, 2024 06:47
felixfontein added a commit that referenced this pull request May 11, 2024
Revert "Fix documentation. (#751)"
Revert "ACME modules: simplify code, refactor argspec handling code, move csr/csr_content to own docs fragment (#750)"
Revert "Refactor and extend argument spec helper, use for ACME modules (#749)"
Revert "Avoid exception if certificate has no AKI in acme_certificate. (#748)"
Revert "ACME: improve acme_certificate docs, include cert_id in acme_certificate_renewal_info return value (#747)"
Revert "Add acme_certificate_renewal_info module (#746)"
Revert "Refactor time code, add tests, fix bug when parsing absolute timestamps that omit seconds (#745)"
Revert "Add tests for acme_certificate_deactivate_authz module. (#744)"
Revert "Create acme_certificate_deactivate_authz module (#741)"
Revert "acme_certificate: allow to request renewal of a certificate according to ARI (#739)"
Revert "Implement basic acme_ari_info module. (#732)"
Revert "Add function for retrieval of ARI information. (#738)"
Revert "acme module utils: add functions for parsing Retry-After header values and computation of ARI certificate IDs (#737)"
Revert "Implement certificate information retrieval code in the ACME backends. (#736)"
Revert "Split up the default acme docs fragment to allow modules ot not need account data. (#735)"

This reverts commits 5e59c52, aa82575,
f3c9cb7, f82b335, 553ab45,
59606d4, 0a15be1, 9501a28,
d906914, 33d278a, 6d4fc58,
9614b09, af5f4b5, c6fbe58,
and afe7f75.
austinlucaslake pushed a commit to austinlucaslake/community.crypto that referenced this pull request May 25, 2024
Revert "Fix documentation. (ansible-collections#751)"
Revert "ACME modules: simplify code, refactor argspec handling code, move csr/csr_content to own docs fragment (ansible-collections#750)"
Revert "Refactor and extend argument spec helper, use for ACME modules (ansible-collections#749)"
Revert "Avoid exception if certificate has no AKI in acme_certificate. (ansible-collections#748)"
Revert "ACME: improve acme_certificate docs, include cert_id in acme_certificate_renewal_info return value (ansible-collections#747)"
Revert "Add acme_certificate_renewal_info module (ansible-collections#746)"
Revert "Refactor time code, add tests, fix bug when parsing absolute timestamps that omit seconds (ansible-collections#745)"
Revert "Add tests for acme_certificate_deactivate_authz module. (ansible-collections#744)"
Revert "Create acme_certificate_deactivate_authz module (ansible-collections#741)"
Revert "acme_certificate: allow to request renewal of a certificate according to ARI (ansible-collections#739)"
Revert "Implement basic acme_ari_info module. (ansible-collections#732)"
Revert "Add function for retrieval of ARI information. (ansible-collections#738)"
Revert "acme module utils: add functions for parsing Retry-After header values and computation of ARI certificate IDs (ansible-collections#737)"
Revert "Implement certificate information retrieval code in the ACME backends. (ansible-collections#736)"
Revert "Split up the default acme docs fragment to allow modules ot not need account data. (ansible-collections#735)"

This reverts commits 5e59c52, aa82575,
f3c9cb7, f82b335, 553ab45,
59606d4, 0a15be1, 9501a28,
d906914, 33d278a, 6d4fc58,
9614b09, af5f4b5, c6fbe58,
and afe7f75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant